Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spacing on save #20

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

TheSharpieOne
Copy link
Contributor

previously spaces between tags would be removed causing words to be put together
with this change spacing is preserved where it can be, but still removed from places spaces cannot be (such as lists)

fixes #18

Kapture 2020-09-15 at 22 12 36

previously spaces between tags would be removed causing words to be put together
with this change spacing is preserved where it can be, but still removed from places spaces cannot be (such as lists)

fixes benwinding#18
@TheSharpieOne
Copy link
Contributor Author

Note: This also addresses a small bug which #6 didn't cover where the <ol>/<ul> and <li> are on the same line with spaces in between.
You can see here with the existing code:
Kapture 2020-09-15 at 22 19 46

Here is with the changes in this PR:
Kapture 2020-09-15 at 22 20 38

@benwinding benwinding merged commit fb82cb6 into benwinding:master Sep 16, 2020
@benwinding
Copy link
Owner

Thanks again @TheSharpieOne
Works great and I appreciate the contribution! 👍
Should be deployed as version quill-html-edit-button@2.0.1

@TheSharpieOne TheSharpieOne deleted the fix/spacing-on-save branch September 16, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Spaces are removed when tags are next to each other
2 participants