Ignore environment variables when executing git command #14
Conversation
Me, neither. I suggest that we
Becomes
And then add a
To the options, with the current implementation as the default. I can fix the Hugo side of this, but the above would allow us to hook this into Hugo's setup for all of this (there is a fairly strict env var filter already in place). |
|
Sounds good to me. Do you want me to try to implement your suggestion in this PR? Or will you take over from here and close this PR? |
If you could make the changes in this PR, I can tag a release and make the Hugo changes. |
|
Done, please let me know if I need to change something. |
gitmap.go
Outdated
| GetGitCommandFunc func(args ...string) *exec.Cmd | ||
| } | ||
|
|
||
| func NewOptions(repository, revision string) Options { |
There was a problem hiding this comment.
Can you
- Remove NewOptions
- Inside Map: Do a
if opts.GetGitCommandFunc == nil then opts.GetGitCommandFunc = the default ...
Other than that this looks good.
FantasyTeddy
force-pushed
the
ignore-environment-variables
branch
from
d570892
to
3328c12
Compare
gitmap.go
Outdated
| out, err := exec.Command(gitExec, args...).CombinedOutput() | ||
| func git(opts Options, args ...string) ([]byte, error) { | ||
| var cmd *exec.Cmd | ||
| if opts.GetGitCommandFunc != nil { |
There was a problem hiding this comment.
I would prefer if we did this in the Map func and set the value on the Options struct; that way we don't have to think about it if we add other git operations (the opt.GetGitCommandFunc is always set).
There was a problem hiding this comment.
Sorry, I did not read your previous comment carefully enough.
FantasyTeddy
force-pushed
the
ignore-environment-variables
branch
from
3328c12
to
04dc645
Compare
We encountered the issue gohugoio/hugo#8627 seemingly random, until we realized that the environment variable
GIT_TRACEwas enabled for debugging.The parsing logic does not handle the additional output very well and therefore panics with the "index out of range" error.
The simplest solution would be to ignore all environment variables.
However, I'm not absolutely sure that this has no unintended side-effects.