Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hard coded text to translation locals #156

Open
kiomarzsss opened this issue May 19, 2024 · 3 comments
Open

add hard coded text to translation locals #156

kiomarzsss opened this issue May 19, 2024 · 3 comments
Labels
good first issue help wanted Extra attention is needed

Comments

@kiomarzsss
Copy link
Collaborator

No description provided.

@kiomarzsss kiomarzsss added help wanted Extra attention is needed good first issue labels May 19, 2024
@Princeyadav05
Copy link

@kiomarzsss can you share more information on this issue?

kiomarzsss added a commit that referenced this issue Jun 3, 2024
@kiomarzsss
Copy link
Collaborator Author

kiomarzsss commented Jun 3, 2024

@Princeyadav05 sorry for the late response. here is the task description:

all the text(except logs) that the end users sees needs to be translated. and shown from one of the files from locale directory(based on user settings if any and else from default settings).

  • some of these text at the moment are hard coded in the source code(mostly in the main process).
  • these text need to be added to all locales and be shown to the end user by the language of user choice(user settings).
  • i tagged these text with TODO locale so they can be easily found (0cd7e55).
  • checkout the implementation of the solution for renderer process here: https://github.com/bepass-org/oblivion-desktop/blob/main/src/renderer/lib/loaders.ts
  • to solve this issue we need something like the work done in renderer process for main process.

if you're considering to work on this issue please read our Contribution Guide first.

ircfspace added a commit that referenced this issue Jun 3, 2024
kiomarzsss added a commit that referenced this issue Jun 7, 2024
kiomarzsss pushed a commit that referenced this issue Jun 7, 2024
@ircfspace
Copy link
Collaborator

The codes related to the multilingual feature have been refactored by @GhostByeBye and are currently not hardcoded,
but we are facing issues for calling the language selected by the user in main.ts, proxy.ts, and wp.ts (in LIB)

We've tried solutions like using cookies, local storage, and electron-store, but they haven't been successful.
For now, we've enforced English as the language until we find a solution to this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted Extra attention is needed
Projects
Status: Next Version
Development

No branches or pull requests

4 participants
@Princeyadav05 @ircfspace @kiomarzsss and others