Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ethereumjs as execution client in kurtosis #884

Merged
merged 9 commits into from
Apr 27, 2024

Conversation

nidhi-singh02
Copy link
Contributor

@nidhi-singh02 nidhi-singh02 commented Apr 24, 2024

Integrate ethereumjs as execution client in kurtosis.
Attaching logs here from the local run -
Screenshot 2024-04-27 at 12 22 10 PM
Screenshot 2024-04-27 at 12 23 00 PM
Screenshot 2024-04-27 at 12 23 23 PM

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.28%. Comparing base (bc601b9) to head (3cd0c1e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   14.28%   14.28%           
=======================================
  Files         183      183           
  Lines        8380     8380           
  Branches       16       16           
=======================================
  Hits         1197     1197           
  Misses       7116     7116           
  Partials       67       67           

@nidhi-singh02 nidhi-singh02 force-pushed the integrate-ethereumjs branch 3 times, most recently from d190432 to a79f034 Compare April 26, 2024 09:39
@nidhi-singh02
Copy link
Contributor Author

@itsdevbear @ocnc I was able to get the containers for ethereumjs up and running by using make start-devnet, I see error in cl-validator-beaconkit and cl-full-beaconkit for ethereumjs as shown below. I have spent quite a time playing around with the ethereumjs options, but no luck so far. I have also take reference from the kurtosis repository.
Let's discuss it once you are available so we could close this.

Screenshot 2024-04-26 at 3 20 33 PM

@itsdevbear
Copy link
Member

@nidhi-singh02 try rebasing main, we had a regression we recently fixed

Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
@nidhi-singh02
Copy link
Contributor Author

@nidhi-singh02 try rebasing main, we had a regression we recently fixed

Tried rebasing but no luck. One observation that I have is - I see above errors in logs with my changes and that too in ethereumjs clients only. I don't see any error in other clients. Might be specific to integrating Ethereumjs.

@itsdevbear
Copy link
Member

Did it happen with single node make command? Could be a peering issue on kurtosis?

Signed-off-by: nidhi-singh02 <trippin@berachain.com>
@nidhi-singh02
Copy link
Contributor Author

Did it happen with single node make command? Could be a peering issue on kurtosis?

Single node make command for ethereumjs works fine. Haha, Thanks for the hint, I figured it out. Using the master version causes those errors. So I switched to stable version, it works.
I am not sure why the ethereum-package works with master image though.

@nidhi-singh02 nidhi-singh02 marked this pull request as ready for review April 27, 2024 06:54
@itsdevbear itsdevbear added this pull request to the merge queue Apr 27, 2024
@itsdevbear
Copy link
Member

Lgtm!

Merged via the queue into main with commit e49b765 Apr 27, 2024
12 checks passed
@itsdevbear itsdevbear deleted the integrate-ethereumjs branch April 27, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants