-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ethereumjs as execution client in kurtosis #884
Conversation
3b68fce
to
de4e396
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
=======================================
Coverage 14.28% 14.28%
=======================================
Files 183 183
Lines 8380 8380
Branches 16 16
=======================================
Hits 1197 1197
Misses 7116 7116
Partials 67 67 |
d190432
to
a79f034
Compare
@itsdevbear @ocnc I was able to get the containers for ethereumjs up and running by using ![]() |
@nidhi-singh02 try rebasing main, we had a regression we recently fixed |
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
Tried rebasing but no luck. One observation that I have is - I see above errors in logs with my changes and that too in ethereumjs clients only. I don't see any error in other clients. Might be specific to integrating Ethereumjs. |
Did it happen with single node make command? Could be a peering issue on kurtosis? |
Signed-off-by: nidhi-singh02 <trippin@berachain.com>
b62cb9e
to
3cd0c1e
Compare
Single node make command for ethereumjs works fine. Haha, Thanks for the hint, I figured it out. Using the master version causes those errors. So I switched to stable version, it works. |
Lgtm! |
Integrate ethereumjs as execution client in kurtosis.
![Screenshot 2024-04-27 at 12 22 10 PM](https://private-user-images.githubusercontent.com/38173192/326160856-66ca7b02-59dc-497b-9754-0487a5551c93.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNTA3MjksIm5iZiI6MTcyMjI1MDQyOSwicGF0aCI6Ii8zODE3MzE5Mi8zMjYxNjA4NTYtNjZjYTdiMDItNTlkYy00OTdiLTk3NTQtMDQ4N2E1NTUxYzkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI5VDEwNTM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxZWU5NTYzOTliMTY5MjlmNmRiYzk0NzczMDk3MDkzYThmNjIwYzA2ZDAzNmQ5NTMzYTZlYWQ3MTA3YTg1ZDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.mdAXkXEjKgF8m4I16gmk7RyYHA7URLHGfgIspNshGpM)
![Screenshot 2024-04-27 at 12 23 00 PM](https://private-user-images.githubusercontent.com/38173192/326160886-cf475efd-e363-4d1c-a46a-54231fab999b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNTA3MjksIm5iZiI6MTcyMjI1MDQyOSwicGF0aCI6Ii8zODE3MzE5Mi8zMjYxNjA4ODYtY2Y0NzVlZmQtZTM2My00ZDFjLWE0NmEtNTQyMzFmYWI5OTliLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI5VDEwNTM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg5NzU5NjE2MDBmZDE5MWU0MDg1ODhhMTU4MzAzNWJmMDVlY2FkNGFmMjBlMTJmOGMwM2IxODZiNGIxMmZkMDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.qe29g-fIcoSnvTL-9NRozhkmzZycqDBlVV6ncezsN2I)
![Screenshot 2024-04-27 at 12 23 23 PM](https://private-user-images.githubusercontent.com/38173192/326160905-6e1faf1d-293c-46ce-ab4d-328918cbf303.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIyNTA3MjksIm5iZiI6MTcyMjI1MDQyOSwicGF0aCI6Ii8zODE3MzE5Mi8zMjYxNjA5MDUtNmUxZmFmMWQtMjkzYy00NmNlLWFiNGQtMzI4OTE4Y2JmMzAzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzI5VDEwNTM0OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYxNWU5NGEzMzlkMjdiNDVlZTNkOGI4MTBjYTYyNGUxMGI4MDcwYTMyMjQ3Y2FmYWVjZmU4YTgxNjFhMmUwYWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.QOo6imlULjJRff2i8cbHAh3cbwz___qM7UkNR4AhFss)
Attaching logs here from the local run -