Extend boolean common functionality to other subtractive features #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an “inverse” option for PartDesign pocket feature. Essentially this cuts away anything that is +not+ covered by the sketch. (boolean common instead of cut.)
in order to keep it consistent with helix feature, also add a more descriptive tool-tip to Outside property in helix
Hole feature is left without this option since it doesn't make sense there
7 tasks
0penBrain
reviewed
Jul 4, 2021
| BRepAlgoAPI_Cut mkCut(base, prism); | ||
| if (!mkCut.IsDone()) | ||
| return new App::DocumentObjectExecReturn("Pocket: Cut out of base feature failed"); | ||
| result = mkCut.Shape(); |
There was a problem hiding this comment.
Suggested change
| result = mkCut.Shape(); | |
| result = this->getSolid(mkCut.Shape()); |
There was a problem hiding this comment.
thanks for the review, pocket originally didn't do this but just used mkCut.Shape() should I assume that was just a mistake and it should have used this method all along? Can you explain what this does?
There was a problem hiding this comment.
ok it turns out this is also done just a few lines after (238):
TopoDS_Shape solRes = this->getSolid(result);
what to do then?
later on result is used again (line 242):
int solidCount = countSolids(result);
There was a problem hiding this comment.
Actually the idea is just to harmonize things. If it's too much work because of existing codebase, then it could stay as is.
| BRepAlgoAPI_Common mkCommon(base, prism); | ||
| if (!mkCommon.IsDone()) | ||
| return new App::DocumentObjectExecReturn("Pocket: Cut out of base feature failed"); | ||
| result = mkCommon.Shape(); |
There was a problem hiding this comment.
Suggested change
| result = mkCommon.Shape(); | |
| result = this->getSolid(mkCommon.Shape()); |
berberic2
pushed a commit
that referenced
this pull request
Aug 25, 2021
Prevent matplotlib selecting the PyQt API instead of PySide2
berberic2
pushed a commit
that referenced
this pull request
Jul 30, 2023
berberic2
pushed a commit
that referenced
this pull request
Apr 1, 2024
The proposed code fixes the following issues: 1. There is no check if the target object itself has a property that matches the label type. 2. If a subelement is selected that does not have the label type property, the value from the main object is displayed instead. 3. The default text is an empty string. Example: Currently If you select a vertex of a wire, and select "Length" as the label type, you will get the length of the wire. With the new code the text will then be "Length not available for (sub)object". Forum topic (issue #1): https://forum.freecad.org/viewtopic.php?t=86222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see my comment in the forum: https://forum.freecadweb.org/viewtopic.php?style=5&f=19&t=59116&p=514324#p514324