Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File naming for density output #111

Closed
Visdoom opened this issue Jul 3, 2020 · 3 comments
Closed

File naming for density output #111

Visdoom opened this issue Jul 3, 2020 · 3 comments
Assignees
Labels

Comments

@Visdoom
Copy link
Contributor

Visdoom commented Jul 3, 2020

Hi @avdaranyi,

while writing the tests I realised that the output filenames for the density maps contain the filename twice.
When I run the command:
./MorphoPy.py -c density -i ../data/EC3-80604.CNG.rotated.swc -o ../tests/test_data/
the output file for the density data is called EC3-80604.CNG.rotated.swc_density_EC3-80604.CNG.rotated.swc_reconstruction_density.mat.

I propose to change the naming such that we have filename_density.[png|mat]. This way the naming is as short as possible and the two files (plot and data) are distinguishable through their file endings.

@Visdoom Visdoom assigned Visdoom and avdaranyi and unassigned Visdoom Jul 3, 2020
@avdaranyi
Copy link
Contributor

Hi @Visdoom ,
the doubled filename is a bug after the change of the input handling. I already solved it, but isn't uploaded. I will upload it soon. But should I really kick out the bin_sizes of the filename? It was a really big thing to do it this way and I think, if you are making various outputs with different bin sizes, it would be nice to have a way to distingush the files.

avdaranyi added a commit that referenced this issue Jul 6, 2020
#111 file naming is working again
@Visdoom
Copy link
Contributor Author

Visdoom commented Jul 7, 2020

@avdaranyi You are right, we should keep the bin sizes in the names. I just think we do not need different names for the png and the mat files, since they are distinguishable by their file ending.

@Visdoom Visdoom added bug and removed enhancement labels Jul 7, 2020
@Visdoom
Copy link
Contributor Author

Visdoom commented Jul 10, 2020

@avdaranyi Can I close this?

@Visdoom Visdoom closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants