feat: code document format #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillLillis
force-pushed
the
format
branch
3 times, most recently
from
2aac906
to
1a7f0d9
Compare
WillLillis
force-pushed
the
format
branch
3 times, most recently
from
aab804a
to
94cb269
Compare
misc cleanup Remove unecessary clone Fix logic bug for file word grab
|
Looking at this again, I don't think it's a good idea to tackle this with regexes. Going to hold off on formatting until we have a more accurate tree-sitter grammar (or some other equivalent tool that understands the code at more than a textual level). One promising lead is amanq's WIP parser described in this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some very basic document formatting as described in #42. Trailing whitespace and newlines are trimmed according to params communicated by the LSP client (with reasonable defaults provided as well). Labels (e.g.
main:) are un-indented as needed, and anything else is given a single indent as needed.I initially tried using tree-sitter for this, but ran into too many errors with the existing asm grammar and ended up using regexes instead. In the future it may make sense to switch over to using tree-sitter for this feature once the existing grammar is better, or if we write our own.
Closes #42