feat: Hover and Autocomplete for Gas directives #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillLillis
changed the title
WillLillis
force-pushed
the
gas_directives
branch
4 times, most recently
from
409669d
to
8e419d6
Compare
WillLillis
force-pushed
the
gas_directives
branch
from
8e419d6
to
128caec
Compare
WillLillis
force-pushed
the
gas_directives
branch
3 times, most recently
from
f687898
to
3f474ee
Compare
WillLillis
force-pushed
the
gas_directives
branch
from
3f474ee
to
cfddd2a
Compare
WillLillis
force-pushed
the
gas_directives
branch
from
cfddd2a
to
e63a68f
Compare
WillLillis
force-pushed
the
gas_directives
branch
from
e63a68f
to
82674fc
Compare
WillLillis
force-pushed
the
gas_directives
branch
from
82674fc
to
6951d8d
Compare
Clean up generic stuff for enums Add uppercase support for directives Fix as decoration in .file directive xml entry Fixed get word bug
WillLillis
force-pushed
the
gas_directives
branch
from
6951d8d
to
3898f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (sorry it's a bit long!) adds hover and autocomplete support for Gas directives. Adding this was relatively straightforward code-wise, as the majority of time went into writing the XML file. I initially looked into writing a python script to pull the information together, but there were enough oddities/ things to manually edit in the docs that I just wrote it by hand (The LuaSnip plugin was very helpful in this regard).
Huge thanks to @Freed-Wu for making the request and linking the relevant documentation!
Closes #46