auotstart an instance on publish if it was already running #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #136
The pull request also makes a switch to pause/resume rather than stop/start as that is considerably faster.
The VM is auto started only if it had been running prior to publish.
It is desirable for the VM to be stopped for publish,, but is not essential. A stopped VM will contain a fixed state (if there were any write operations running). For safety, it may be desirable, to prevent the user from publishing a Running VM and force the user to manually stop/pause it to ensure the user remains in control of the final publishable VM step.
Can have a discussion about this and incorporate into this PR if desirable.