Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DH-3] try using a test fork of the chp #5501

Merged
merged 9 commits into from
Feb 27, 2024
Merged

[DH-3] try using a test fork of the chp #5501

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7d64de1
try using a test fork of the chp
shaneknapp Feb 2, 2024
1f50327
add timeout and proxytimeout args
shaneknapp Feb 2, 2024
17dc0c0
add reference url for reference
shaneknapp Feb 2, 2024
858e0c9
s/ /=/
shaneknapp Feb 2, 2024
bb8e6e8
add a dash to cli arg
shaneknapp Feb 3, 2024
7f216c9
chartpressed
shaneknapp Feb 3, 2024
9c1949f
remove timeouts
shaneknapp Feb 9, 2024
d97afe2
bump proxy ram as we have plenty
shaneknapp Feb 21, 2024
f928307
chartpressed
shaneknapp Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions hub/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,20 @@ jupyterhub:
service:
type: ClusterIP
chp:
# testing out a potential fix for the chp leaking ports
# https://github.com/jupyterhub/configurable-http-proxy/issues/434
# https://github.com/jupyterhub/configurable-http-proxy/issues/434#issuecomment-1924261459
# https://github.com/http-party/node-http-proxy/pull/1559
# https://github.com/Jimbly/http-proxy-node16/commit/56283e33edfc7aad8c2605dd493da8a196b4371d
# https://github.com/consideRatio/configurable-http-proxy/commits/main/
#
image:
tag: 4.6.1-fork
extraCommandLineFlags:
# set the timeout and proxyTimeout to 24 hours (arg is in milliseconds)
# https://github.com/http-party/node-http-proxy?tab=readme-ov-file#options
- "--timeout 86400000"
shaneknapp marked this conversation as resolved.
Show resolved Hide resolved
- "--proxyTimeout 86400000"
shaneknapp marked this conversation as resolved.
Show resolved Hide resolved
resources:
requests:
# FIXME: We want no guarantees here!!!
Expand Down