Added gaussian filter to preprocess script #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlonDaks
force-pushed
the
classification
branch
from
935c2bb
to
843ec12
Compare
| data = img.get_data() | ||
| if j == 0: | ||
| run_data.append(data[..., :-4]) | ||
| elif j >= 1 and j <= 6: |
There was a problem hiding this comment.
should clarify what 1 and 6 mean
and doesn't this depend on NUM_RUNS? I think it would be more intuitive if it says NUM_RUNS - 1 instead of 6
There was a problem hiding this comment.
You're right -- it rephrased 6 in terms of NUM_RUNS - 2
|
i think documentation would be helpful, not exactly sure where you're getting a lot of constants, and what each function requires |
|
I will add documentation in the next PR -- working to close this so I can begin testing on Amazon EC2 |
|
Ok I'll approve this. Just to be sure to add documentation for the next PR |
lisaannyu
added a commit
that referenced
this pull request
Dec 11, 2015
Added gaussian filter to preprocess script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.