Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for lme #108

Merged
merged 5 commits into from
Dec 12, 2015
Merged

Add test for lme #108

merged 5 commits into from
Dec 12, 2015

Conversation

BenjaminHsieh
Copy link
Contributor

Added test for lme functions, please check

@boyinggong I noticed you included a bonferroni correction on the prop of anova that are significant (anovaStat) but not for the propotion of beta -pvalues (calcSigProp). Should we add the correction?

@BenjaminHsieh
Copy link
Contributor Author

Added test for smoothing function, please check

@@ -75,7 +66,7 @@
sig_gain_prop[i-1], sig_loss_prop[i-1] = calcSigProp(beta, sig_level)
write=pathtofolder + 'ds005/sub0'+str(i).zfill(2)+'/model/model001/onsets/sub0'+str(i).zfill(2)+'_lme_beta.txt'
np.savetxt(write, beta)
anov_test = calcAnov(data_full, run_group)
anov_test = calcAnov(data_full, run_group, thrshd)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be thrshd = None?

Looks good to me but I didn't run it yet

Edit: jk just saw thrshd = 400

@BenjaminHsieh
Copy link
Contributor Author

is this good ?

@BenjaminHsieh
Copy link
Contributor Author

Lets mege this

changsiyao added a commit that referenced this pull request Dec 12, 2015
@changsiyao changsiyao merged commit 349e1b8 into berkeley-stat159:dev Dec 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants