Dev #110
Merged
Dev #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import numpy as np | ||
| import matplotlib.pyplot as plt | ||
|
|
||
| def plot_roc(logreg_proba, y): |
There was a problem hiding this comment.
what's the y input here?
|
I believe the y are the actual responses (0 or 1), @boyinggong can you make some comments to the function |
|
Sorry I've updated the comments. |
Closed
|
Check #112 |
|
@BenjaminHsieh I've combined the code into the logistic_function.py and logistic.py file. I also update the code to subplot all figures into one. Please check it and let me know if there is any error. |
|
Cool, can you also add a subject label at the top of each ROC graph? |
|
I am going to merge this for now, we can add the subject label later |
BenjaminHsieh
added a commit
that referenced
this pull request
Dec 12, 2015
Merging for now, add subject label later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add confusion matrix and ROC curve