Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an order issue in code/scripts, minor edits #146

Merged
merged 4 commits into from
Dec 14, 2015

Conversation

briankleinqiu
Copy link
Contributor

So graph_lin_diagnostics is saving res_fitted_log and res_fitted to the paper/figures directory and not the results/figures directory.

We want to fix that right?

Also, the graph looks a little weird to me now.

res_fitted

@changsiyao
Copy link
Contributor

We can fix it if you want to, it's not necessary, since we are just generating this one plot that's included in the paper.
Also, in code/Makefile, make diagnostics needs to be before make glm, like you said, can you fix that as well.

@briankleinqiu
Copy link
Contributor Author

Ok, not worried about the path too much really. It's more that the plot looks strange to me, does it look weird to you? When you run make diagnostics that's the plot that'll get pushed to the paper/figure so that's the one that could end up in our paper

@changsiyao
Copy link
Contributor

@BenjaminHsieh Were you getting this plot when you plotted a while ago?

@BenjaminHsieh
Copy link
Contributor

no, i had something different I think this may be a floating int problem that matthew was talking about

@BenjaminHsieh
Copy link
Contributor

when loading in the BOLD image/getting the data, try the astype(float), something like this:

img = nib.load("our data nii") data = img.get_data().astype(float) [do other work]
@changsiyao

@BenjaminHsieh
Copy link
Contributor

@BrianQIu

@changsiyao
Copy link
Contributor

So we have to go in and change all the scripts with that?

@BenjaminHsieh
Copy link
Contributor

ummm probably...lol, see if this fixes the res vs actual first

@BenjaminHsieh
Copy link
Contributor

yeah i think just change it for the res vs actual plot, b/c we dont have time to run the other things again and the results look ok

@changsiyao
Copy link
Contributor

In script/neural_behavial_plot.py, line 17, "from neural_behavior import plot_neur_beh" needs to be changed to "from plot_neural_behavior import plot_neur_beh", @BrianQIu can you change it with this pull request?

@briankleinqiu
Copy link
Contributor Author

will do in a bit. laptop is crapping out on me right now as im running make glmstandard

@briankleinqiu
Copy link
Contributor Author

nice fix ben, that worked. can prbly merge in now.
res_fitted

BenjaminHsieh added a commit that referenced this pull request Dec 14, 2015
fix an order issue in code/scripts, minor edits
@BenjaminHsieh BenjaminHsieh merged commit 50bd5cc into berkeley-stat159:dev Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants