-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix an order issue in code/scripts, minor edits #146
Conversation
We can fix it if you want to, it's not necessary, since we are just generating this one plot that's included in the paper. |
Ok, not worried about the path too much really. It's more that the plot looks strange to me, does it look weird to you? When you run make diagnostics that's the plot that'll get pushed to the paper/figure so that's the one that could end up in our paper |
@BenjaminHsieh Were you getting this plot when you plotted a while ago? |
no, i had something different I think this may be a floating int problem that matthew was talking about |
when loading in the BOLD image/getting the data, try the astype(float), something like this:
|
So we have to go in and change all the scripts with that? |
ummm probably...lol, see if this fixes the res vs actual first |
yeah i think just change it for the res vs actual plot, b/c we dont have time to run the other things again and the results look ok |
In script/neural_behavial_plot.py, line 17, "from neural_behavior import plot_neur_beh" needs to be changed to "from plot_neural_behavior import plot_neur_beh", @BrianQIu can you change it with this pull request? |
will do in a bit. laptop is crapping out on me right now as im running make glmstandard |
fix an order issue in code/scripts, minor edits
So graph_lin_diagnostics is saving res_fitted_log and res_fitted to the paper/figures directory and not the results/figures directory.
We want to fix that right?
Also, the graph looks a little weird to me now.