-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change path in data.py to fix travis CI fail #29
Conversation
Maybe need to import os first |
do you mean in the data file? |
ok finally go it to work, the coverage will decrease because the hashList is being loaded from the call to main, which is ignored by travis ci. Anyway, this should work for everyone, someone can merge and test it out |
Can also close #14 |
Wait, I'm having problem with this file. If I change directory to the folder above, then the path for all the files are wrong. I got this. I think we need to change the directory back after loading the hashList, like: |
hmmm, weird, I have the opposite, if I add oc.chdir('data/') before check_hashes(d), then I get that same error |
Other people should check, otherwise, let's ask tmr in office hours. |
@changsiyao try this, I have this that works: if name == "main": |
this assumes that you have the ds005/ in data directory |
This (without all the changing directory steps) works for me, but I thought this wouldn't pass the test? |
lol it passed just now |
lets get someone else to check just in case and if its good we can merge it |
eh...... But I suppose it's a good thing, lol~ |
can someone test this and merge it thanks, it will probably allow us to pass the failure in #31 @boyinggong @BrianQIu @pigriver123 |
Change path in data.py to fix travis CI fail
Check to see if travis ci passes