-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Clean up #207
Merged
jarrodmillman
merged 14 commits into
berkeley-stat222:master
from
jarrodmillman:clean-up
May 14, 2016
Merged
WIP: Clean up #207
jarrodmillman
merged 14 commits into
berkeley-stat222:master
from
jarrodmillman:clean-up
May 14, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` $ find . -type f -name "*.py" | xargs autopep8 -i ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I review the code and text of your final project today, I will make edits and clean things up as I go. In particular, I will fix the formatting on all the docstrings so that the autogenerated API documentation looks nice. You can see the the API docs here:
http://berkeley-stat222.github.io/mousestyles/api/mousestyles.html
I will also try to make some changes to make the report more visually consistent. For example, if you look at the table of contents (http://berkeley-stat222.github.io/mousestyles/report/index.html) of the report you will see that some section headings have colons in them and some don't, some sections are capitalized ("Statement of Problem") and some are not ("Statement of problem").
I will also fix any warnings that are produced when building the documentation. Finally, I will remove some code that doesn't appear to have been used or improved:
intervals.py
pca_hcm_data.py
strain_classification.py
This should make it clearer what code is yours as well as improve the test coverage.