Merge branch 'release/0.4.0'

* release/0.4.0: bump version removing spec for routing. Payments were not verified. Fixed. Update to latest spree 1.0.x. Added description and maintenance notes. Lock sources for Ruby 1.9.x remove rvmrc
berkes · Jan 22, 2013 · 24fe853 · 24fe853
2 parents 05dc213 + 3e9ea84
commit 24fe853
Show file tree

Hide file tree

Showing 8 changed files with 142 additions and 153 deletions.
diff --git a/.rvmrc b/.rvmrc
diff --git a/Gemfile b/Gemfile
@@ -1,12 +1,11 @@
-source 'http://rubygems.org'
+source :rubygems
 
 group :test do
+  gem 'rspec-rails', '~> 2.12.2'
   gem 'spork'
-  gem 'autotest'
-  gem 'autotest-rails'
-  gem 'autotest-notification'
-  gem 'spree_auth'
+  gem 'factory_girl', '~> 2'
   gem 'ffaker'
+  gem 'sqlite3'
 end
 
 if RUBY_VERSION < "1.9"

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -2,27 +2,26 @@ PATH
   remote: .
   specs:
     spree_omnikassa (0.3.0)
-      spree_core (~> 1.0.0)
+      spree (~> 1.0.6)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    ZenTest (4.6.2)
-    actionmailer (3.1.3)
-      actionpack (= 3.1.3)
-      mail (~> 2.3.0)
-    actionpack (3.1.3)
-      activemodel (= 3.1.3)
-      activesupport (= 3.1.3)
+    actionmailer (3.1.10)
+      actionpack (= 3.1.10)
+      mail (~> 2.3.3)
+    actionpack (3.1.10)
+      activemodel (= 3.1.10)
+      activesupport (= 3.1.10)
       builder (~> 3.0.0)
       erubis (~> 2.7.0)
       i18n (~> 0.6)
-      rack (~> 1.3.5)
-      rack-cache (~> 1.1)
+      rack (~> 1.3.6)
+      rack-cache (~> 1.2)
       rack-mount (~> 0.8.2)
       rack-test (~> 0.6.1)
-      sprockets (~> 2.0.3)
-    active_utils (1.0.3)
+      sprockets (~> 2.0.4)
+    active_utils (1.0.5)
       activesupport (>= 2.3.11)
       i18n
     activemerchant (1.20.1)
@@ -33,73 +32,60 @@ GEM
       i18n
       json (>= 1.5.1)
       money (<= 3.7.1)
-    activemodel (3.1.3)
-      activesupport (= 3.1.3)
+    activemodel (3.1.10)
+      activesupport (= 3.1.10)
       builder (~> 3.0.0)
       i18n (~> 0.6)
-    activerecord (3.1.3)
-      activemodel (= 3.1.3)
-      activesupport (= 3.1.3)
-      arel (~> 2.2.1)
+    activerecord (3.1.10)
+      activemodel (= 3.1.10)
+      activesupport (= 3.1.10)
+      arel (~> 2.2.3)
       tzinfo (~> 0.3.29)
-    activeresource (3.1.3)
-      activemodel (= 3.1.3)
-      activesupport (= 3.1.3)
-    activesupport (3.1.3)
-      multi_json (~> 1.0)
+    activeresource (3.1.10)
+      activemodel (= 3.1.10)
+      activesupport (= 3.1.10)
+    activesupport (3.1.10)
+      multi_json (>= 1.0, < 1.3)
     acts_as_list (0.1.4)
-    arel (2.2.1)
-    autotest (4.4.6)
-      ZenTest (>= 4.4.1)
-    autotest-notification (2.3.4)
-      autotest-standalone (~> 4.5)
-    autotest-rails (4.1.2)
-      ZenTest (~> 4.5)
-    autotest-standalone (4.5.9)
+    arel (2.2.3)
     bcrypt-ruby (3.0.1)
-    braintree (2.13.4)
+    braintree (2.22.0)
       builder (>= 2.0.0)
-    builder (3.0.0)
+    builder (3.0.4)
     cancan (1.6.7)
-    capybara (1.0.1)
-      mime-types (>= 1.16)
-      nokogiri (>= 1.3.3)
-      rack (>= 1.0.0)
-      rack-test (>= 0.5.4)
-      selenium-webdriver (~> 2.0)
-      xpath (~> 0.1.4)
-    childprocess (0.3.1)
-      ffi (~> 1.0.6)
-    cocaine (0.2.1)
+    climate_control (0.0.3)
+      activesupport (>= 3.0)
+    cocaine (0.5.1)
+      climate_control (>= 0.0.3, < 1.0)
     columnize (0.3.6)
-    deface (0.7.2)
+    deface (0.9.1)
       nokogiri (~> 1.5.0)
-      rails (>= 3.0.9)
+      rails (~> 3.1)
     devise (1.4.8)
       bcrypt-ruby (~> 3.0)
       orm_adapter (~> 0.0.3)
       warden (~> 1.0.3)
     diff-lcs (1.1.3)
     erubis (2.7.0)
-    factory_girl (2.6.0)
+    factory_girl (2.6.4)
       activesupport (>= 2.3.9)
     ffaker (1.12.1)
-    ffi (1.0.11)
     highline (1.6.8)
     hike (1.2.1)
-    i18n (0.6.0)
+    httparty (0.8.3)
+      multi_json (~> 1.0)
+      multi_xml
+    i18n (0.6.1)
     jquery-rails (1.0.19)
       railties (~> 3.0)
       thor (~> 0.14)
-    json (1.6.5)
-    json_pure (1.6.5)
-    kaminari (0.13.0)
+    json (1.7.6)
+    kaminari (0.14.1)
       actionpack (>= 3.0.0)
       activesupport (>= 3.0.0)
-      railties (>= 3.0.0)
     linecache (0.46)
       rbx-require-relative (> 0.0.4)
-    mail (2.3.0)
+    mail (2.3.3)
       i18n (>= 0.4.0)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
@@ -108,125 +94,131 @@ GEM
       activerecord (~> 3.1.0)
       activesupport (~> 3.1.0)
       polyamorous (~> 0.5.0)
-    mime-types (1.17.2)
+    mime-types (1.19)
     money (3.7.1)
       i18n (~> 0.4)
-    multi_json (1.1.0)
+    multi_json (1.2.0)
+    multi_xml (0.5.2)
     nested_set (1.6.8)
       activerecord (>= 3.0.0)
       railties (>= 3.0.0)
-    nokogiri (1.5.0)
-    orm_adapter (0.0.6)
-    paperclip (2.5.0)
+    nokogiri (1.5.6)
+    orm_adapter (0.0.7)
+    paperclip (2.7.0)
       activerecord (>= 2.3.0)
       activesupport (>= 2.3.2)
       cocaine (>= 0.0.2)
       mime-types
     polyamorous (0.5.0)
       activerecord (~> 3.0)
     polyglot (0.3.3)
-    rack (1.3.6)
-    rack-cache (1.1)
+    rack (1.3.9)
+    rack-cache (1.2)
       rack (>= 0.4)
     rack-mount (0.8.3)
       rack (>= 1.0.0)
     rack-ssl (1.3.2)
       rack
-    rack-test (0.6.1)
+    rack-test (0.6.2)
       rack (>= 1.0)
-    rails (3.1.3)
-      actionmailer (= 3.1.3)
-      actionpack (= 3.1.3)
-      activerecord (= 3.1.3)
-      activeresource (= 3.1.3)
-      activesupport (= 3.1.3)
+    rails (3.1.10)
+      actionmailer (= 3.1.10)
+      actionpack (= 3.1.10)
+      activerecord (= 3.1.10)
+      activeresource (= 3.1.10)
+      activesupport (= 3.1.10)
       bundler (~> 1.0)
-      railties (= 3.1.3)
-    railties (3.1.3)
-      actionpack (= 3.1.3)
-      activesupport (= 3.1.3)
+      railties (= 3.1.10)
+    railties (3.1.10)
+      actionpack (= 3.1.10)
+      activesupport (= 3.1.10)
       rack-ssl (~> 1.3.2)
       rake (>= 0.8.7)
       rdoc (~> 3.4)
       thor (~> 0.14.6)
-    rake (0.9.2.2)
+    rake (10.0.3)
     rbx-require-relative (0.0.5)
     rdoc (3.12)
       json (~> 1.4)
-    rspec (2.8.0)
-      rspec-core (~> 2.8.0)
-      rspec-expectations (~> 2.8.0)
-      rspec-mocks (~> 2.8.0)
-    rspec-core (2.8.0)
-    rspec-expectations (2.8.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.8.0)
-    rspec-rails (2.8.1)
+    rspec-core (2.12.2)
+    rspec-expectations (2.12.1)
+      diff-lcs (~> 1.1.3)
+    rspec-mocks (2.12.1)
+    rspec-rails (2.12.2)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       railties (>= 3.0)
-      rspec (~> 2.8.0)
+      rspec-core (~> 2.12.0)
+      rspec-expectations (~> 2.12.0)
+      rspec-mocks (~> 2.12.0)
     ruby-debug (0.10.4)
       columnize (>= 0.1)
       ruby-debug-base (~> 0.10.4.0)
     ruby-debug-base (0.10.4)
       linecache (>= 0.3)
-    rubyzip (0.9.6.1)
-    selenium-webdriver (2.13.0)
-      childprocess (>= 0.2.1)
-      ffi (~> 1.0.9)
-      json_pure
-      rubyzip
-    spork (0.9.0)
-    spree_auth (1.0.0)
+    spork (0.9.2)
+    spree (1.0.6)
+      spree_api (= 1.0.6)
+      spree_auth (= 1.0.6)
+      spree_cmd (= 1.0.6)
+      spree_core (= 1.0.6)
+      spree_dash (= 1.0.6)
+      spree_promo (= 1.0.6)
+      spree_sample (= 1.0.6)
+    spree_api (1.0.6)
+      spree_auth (= 1.0.6)
+      spree_core (= 1.0.6)
+    spree_auth (1.0.6)
       cancan (= 1.6.7)
       devise (= 1.4.8)
-      spree_core (= 1.0.0)
-    spree_core (1.0.0)
+      spree_core (= 1.0.6)
+    spree_cmd (1.0.6)
+    spree_core (1.0.6)
       activemerchant (= 1.20.1)
       acts_as_list (= 0.1.4)
-      deface (>= 0.7.2)
+      deface (>= 0.9.0)
       ffaker (~> 1.12.0)
       highline (= 1.6.8)
       jquery-rails (>= 1.0.18, <= 1.0.19)
       kaminari (>= 0.13.0)
       meta_search (= 1.1.1)
       nested_set (= 1.6.8)
-      paperclip (= 2.5.0)
-      rails (>= 3.1.1, <= 3.1.3)
+      paperclip (= 2.7.0)
+      rails (~> 3.1.6)
       state_machine (= 1.1.1)
-      stringex (~> 1.3.0)
-    sprockets (2.0.3)
+      stringex (~> 1.3.2)
+    spree_dash (1.0.6)
+      httparty (~> 0.8.1)
+      spree_core (= 1.0.6)
+    spree_promo (1.0.6)
+      spree_auth (= 1.0.6)
+      spree_core (= 1.0.6)
+    spree_sample (1.0.6)
+      spree_core (= 1.0.6)
+    sprockets (2.0.4)
       hike (~> 1.2)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
     sqlite3 (1.3.5)
     state_machine (1.1.1)
-    stringex (1.3.2)
+    stringex (1.3.3)
     thor (0.14.6)
     tilt (1.3.3)
-    treetop (1.4.10)
+    treetop (1.4.12)
       polyglot
       polyglot (>= 0.3.1)
-    tzinfo (0.3.31)
+    tzinfo (0.3.35)
     warden (1.0.6)
       rack (>= 1.0)
-    xpath (0.1.4)
-      nokogiri (~> 1.3)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  autotest
-  autotest-notification
-  autotest-rails
-  capybara (= 1.0.1)
-  factory_girl
+  factory_girl (~> 2)
   ffaker
-  rspec-rails (~> 2.7)
+  rspec-rails (~> 2.12.2)
   ruby-debug
   spork
-  spree_auth
   spree_omnikassa!
   sqlite3
diff --git a/README.md b/README.md
@@ -1,21 +1,36 @@
 SpreeOmnikassa
 ==============
 
-Introduction goes here.
+A [Spree payment method](http://guides.spreecommerce.com/payment_gateways.html) for the [Dutch Rabobank Omnikassa](http://www.rabobank.nl/bedrijven/producten/betalen_en_ontvangen/geld_ontvangen/rabo_omnikassa/). 
 
+It was developed for [Anna Treurniet](http://annatreurniet.nl) and
+mentioned in the [whitepaper on my blog](http://berk.es/2012/10/22/spree-on-budgethoster-site5/).
 
-Example
-=======
+It was developed to "just work" and not more. It is unmaintained and
+might not work. 
 
-Example goes here.
+The reason for that is Spree's lack of any kind of support for offsite
+payments. Omnikassa is offsite. And as such it needs to be hacked into
+Spree; with many ugly overrides. 
+On said site, it _works_, but this plugin breaks many things, due to the
+hackish way it needs to override the checkout workflow.
+
+* Coupons break; you cannot have coupons.
+* You cannot run it togeter with other payment methods.
+* Somehow the user-registration breaks, you can only run with anon users
+  and even then in the backend some sub-sub-menu throws a 500-error.
+* It is tightly coupled to Spree 1.0. And upgrading requires quit
+  extensive hacks or re-doing parts of the decorators.
+
+I am severely dissapointed in the stubborn nature of Spree in this. As
+such, I have no plans to upgrade this to a recent version. I have no
+plans to maintain it, untill maybe Spree becomes more of a DSL for
+e-commerce rather then a complete, turnkey solution with all sorts of
+assumptions. Assumptions such as "payments are always done through gateways".
 
 Testing
 -------
 
-Be sure to bundle your dependencies and then create a dummy test app for the specs to run against.
-
-    $ bundle
-    $ bundle exec rake test app
-    $ bundle exec rspec spec
+I had plans to maintain and continue this extension; Hence I started off the extension with Rspec-coverage. Feel free to fork and continue this extension and when doing so, consider updating or removing the RSpec specs.
 
-Copyright (c) 2012 [name of extension creator], released under the New BSD License
+Copyright (c) 2012 Bèr Kessels, released under the New BSD License