Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lumen logo on error pages #520

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Conversation

peter-hank
Copy link
Contributor

Ready for merge?

YES

What does this PR do?

Fixes the Lumen database logo on the all error pages.

How can a reviewer manually see the effects of these changes?

Run the application in the production mode and provoke it to throw errors.

What are the relevant tickets?

Todo:

- [ ] Tests
- [ ] Documentation
- [ ] Stakeholder approval

Requires Database Migrations?

NO

Includes new or updated dependencies?

NO

@peter-hank
Copy link
Contributor Author

I've decided to keep it simple and just add the image to the public folder instead of converting all the templates to erb. It's simpler and faster, it's just plain HTML. We could use the image in the maintenance page template too.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 834

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.509%

Totals Coverage Status
Change from base Build 832: 0.0%
Covered Lines: 1742
Relevant Lines: 2086

💛 - Coveralls

@thatandromeda
Copy link
Contributor

public is great - nothing to worry about if the app 500s and borks the asset pipeline.

@thatandromeda thatandromeda merged commit 8f3d2b2 into dev Jan 22, 2019
@thatandromeda thatandromeda deleted the 16042_fix_lumen_logo_error_pages branch January 22, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants