16041 16103 uncache #524
Merged
16041 16103 uncache #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for merge?
YES
What does this PR do?
Fixes overly aggressive caching bugs.
Helpful background context (if appropriate)
There are only two hard things in computer science...
How can a reviewer manually see the effects of these changes?
Perform the behavior in the tickets, except it yields the desired behavior. Make sure that you have caching turned on first and that you've performed at least one search in order to have it cached.
What are the relevant tickets?
Screenshots (if appropriate)
Todo:
[ ] DocumentationRequires Database Migrations?
NO
Includes new or updated dependencies?
NO