Prevent deep pagination #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes bots try to hit us by cycling through values of the page parameter. This results in lots of errors in our logs (due to elasticsearch limits on the number of results returned). Also, deeper pages are much more resource-intensive for us to render. Therefore, let's simply prevent people from accessing impossible pages, and restrict non-logged-in users.
Pull Request Test Coverage Report for Build 914
💛 - Coveralls |
jsdiaz
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for merge?
NO
Requires stakeholder approval; conversations in progress.
What does this PR do?
This prevents users from requesting search result pages past page 2000 (which just causes an elasticsearch error). It also prevents them from going too far into the search results unless they're authenticated or using the API, because it's computationally more intensive for us to serve those, and casual users are unlikely to page very far in.
Helpful background context (if appropriate)
How can a reviewer manually see the effects of these changes?
Try visiting a search page with
page=10,page=11,page=11while you are logged in, andpage=2001.Your localhost elasticsearch config may throw errors before page 2001, but production supports through 2000.
What are the relevant tickets?
n/a
Screenshots (if appropriate)
Todo:
Requires Database Migrations?
NO
Includes new or updated dependencies?
NO