Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rabbi and cantor to list of religious titles #24

Merged
merged 2 commits into from Jan 8, 2018

Conversation

benbalter
Copy link
Contributor

Great project! This pull request adds rabbi and cantor to the list of recognized religious titles (like father or pastor).

I believe I did it right. I updated parser.y, ran bundle exec rake racc, wrote a test, and committed the results.

Testing locally, the titles are recognized as expected.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.81% when pulling 0b9c5e0 on benbalter:add-rabbi-and-cantor into eab5cb1 on berkmancenter:master.

@inukshuk inukshuk merged commit 898c37e into berkmancenter:master Jan 8, 2018
@inukshuk
Copy link
Member

inukshuk commented Jan 8, 2018

Thanks!

Just a quick note that these titles are used by the lexer only; that means you don't need to recompile the grammar if they change and, more importantly, they can be changed dynamically. I say this because the matches in the title can be problematic (e.g., if you have proper names 'Pastor' or 'Rabbi' etc.). So the patterns in the options are really intended as examples and you may want to adjust them to your locale.

@benbalter benbalter deleted the add-rabbi-and-cantor branch January 8, 2018 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants