Added allow anonymous dropdown select in edit instances #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-hank
requested changes
Jun 10, 2019
peter-hank
reviewed
Jun 17, 2019
peter-hank
requested changes
Jun 21, 2019
|
@singhsanket143 looks great, thanks |
peter-hank
reviewed
Jun 24, 2019
client/views/edit/edit.js
Outdated
| @@ -32,6 +32,7 @@ Template.edit.events({ | |||
| const stale = template.$('select[name=stale_length]').val(); | |||
| const isHidden = (template.$('select[name=visibility]').val() === 'hidden'); | |||
| const social = (template.$('select[name=social]').val() === 'on'); | |||
| const anonymous = template.$('select[name=anonymous]').val() === 'on'; // Fetch the anonymous value from the dropdown | |||
There was a problem hiding this comment.
@singhsanket143 can you move this comment up?
There was a problem hiding this comment.
@peter-hank Updated the comments here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request is implementation for the feature listed in issue #16613. The allow anonymous functionality is now added to the edit instance feature. User can now anytime change the allow anonymous reply option by navigating to the edit advanced features section of an instance.