Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature remote control highlight #134

Merged

Conversation

singhsanket143
Copy link
Contributor

The pull request is implementation for the feature listed in issue #16863. Implementation of Remote control of a projected instance from another device has been implemented in this pull request. The package named yuukan:streamy has been used to establish real-time communication between different devices. Whenever the admin checks the highlight instance checkbox all the other devices will show the effect of emphasizing and de-emphasizing on them.

  1. From the admin end.
    image

  2. From the other user end
    image

Copy link
Contributor

@peter-hank peter-hank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singhsanket143 the whole implementation is on the client side and people with skills will be able to fake it, can you make sure it's not possible?

server/methods.js Outdated Show resolved Hide resolved
server/methods.js Outdated Show resolved Hide resolved
server/methods.js Outdated Show resolved Hide resolved
server/methods.js Outdated Show resolved Hide resolved
server/methods.js Outdated Show resolved Hide resolved
Copy link
Contributor

@peter-hank peter-hank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes.

Copy link
Contributor

@peter-hank peter-hank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singhsanket143

Not all of the requested changes are done. Can you go through this again?

Copy link
Contributor

@peter-hank peter-hank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still overcomplicated.

The logic should be:

  • click on the highlight button
  • check on the server part if the user is admin
  • if so, broadcast and apply on the client side, if not don't do anything

Can you try to simplify it?

@singhsanket143
Copy link
Contributor Author

It's still overcomplicated.

The logic should be:

  • click on the highlight button
  • check on the server part if the user is admin
  • if so, broadcast and apply on the client side, if not don't do anything

Can you try to simplify it?

@peter-hank I have tried to simplify the code. Please review it.

@peter-hank
Copy link
Contributor

@singhsanket143 can you make the Highlight the question label clickable?

@singhsanket143
Copy link
Contributor Author

@singhsanket143 can you make the Highlight the question label clickable?

@peter-hank So on clicking checkbox as well as on label the highlight action should occur?

@singhsanket143
Copy link
Contributor Author

@singhsanket143 can you make the Highlight the question label clickable?

@peter-hank added the clickable label

@peter-hank peter-hank merged commit 7a6fa82 into berkmancenter:dev Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants