-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature remote control highlight #134
Feature remote control highlight #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@singhsanket143 the whole implementation is on the client side and people with skills will be able to fake it, can you make sure it's not possible?
…into Feature_Remote_Control_Highlight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all of the requested changes are done. Can you go through this again?
…ight feature by rmeoving user data from client side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still overcomplicated.
The logic should be:
- click on the highlight button
- check on the server part if the user is admin
- if so, broadcast and apply on the client side, if not don't do anything
Can you try to simplify it?
@peter-hank I have tried to simplify the code. Please review it. |
@singhsanket143 can you make the |
@peter-hank So on clicking checkbox as well as on label the highlight action should occur? |
@peter-hank added the clickable label |
The pull request is implementation for the feature listed in issue #16863. Implementation of Remote control of a projected instance from another device has been implemented in this pull request. The package named yuukan:streamy has been used to establish real-time communication between different devices. Whenever the admin checks the highlight instance checkbox all the other devices will show the effect of emphasizing and de-emphasizing on them.
From the admin end.
From the other user end