Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute paths in tarball package #1857

Open
inopinatus opened this issue Feb 20, 2021 · 0 comments · May be fixed by #1858
Open

Absolute paths in tarball package #1857

inopinatus opened this issue Feb 20, 2021 · 0 comments · May be fixed by #1858

Comments

@inopinatus
Copy link

Description

Prior to 3634ce3, the result of berks package looked like this:

$ tar ztf working_cookbooks.tar.gz | head -3
cookbooks
cookbooks/apt
cookbooks/apt/CHANGELOG.md

Afterwards, they look like this, i.e. with the absolute filenames of a tmpdir from the machine that built them:

$ tar ztf cookbooks-1613803335.tar.gz  | head -3
/var/folders/lq/cjfywhkn46dc7fn3pqvcxq8r0000gn/T/d20210220-71556-1vrjt4w/cookbooks
/var/folders/lq/cjfywhkn46dc7fn3pqvcxq8r0000gn/T/d20210220-71556-1vrjt4w/cookbooks/apt
/var/folders/lq/cjfywhkn46dc7fn3pqvcxq8r0000gn/T/d20210220-71556-1vrjt4w/cookbooks/apt/CHANGELOG.md

This broke our stuff.

Berkshelf Version

7.2.0
inopinatus added a commit to inopinatus/berkshelf that referenced this issue Feb 22, 2021
@inopinatus
Create package with relative paths.
d46cd33 
Decorate minitar's output writer to add files using paths relative
to the source directory.

Fixes: berkshelf#1857
@inopinatus inopinatus linked a pull request Feb 22, 2021 that will close this issue
Open
inopinatus added a commit to inopinatus/berkshelf that referenced this issue Feb 22, 2021
@inopinatus
Create package with relative paths.
b38c5c1 
Decorate minitar's output writer to add files using paths relative
to the source directory.

Fixes: berkshelf#1857
inopinatus added a commit to inopinatus/berkshelf that referenced this issue Feb 22, 2021
@inopinatus
Create package with relative paths.
655b004 
Decorate minitar's output writer to add files using paths relative
to the source directory.

Fixes: berkshelf#1857
This was referenced Mar 5, 2021
Open
Closed
inopinatus added a commit to inopinatus/berkshelf that referenced this issue Oct 1, 2021
@inopinatus
Create package with relative paths.
acd33df 
Decorate minitar's output writer to add files using paths relative
to the source directory.

Fixes: berkshelf#1857
@lamont-granquist lamont-granquist mentioned this issue Dec 14, 2021
Closed
3 tasks
@i5pranay93 i5pranay93 mentioned this issue Jun 1, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@inopinatus