Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendoring removes the metadata.rb breaking foodcritic #931

Closed
sbates opened this issue Dec 2, 2013 · 4 comments
Closed

Vendoring removes the metadata.rb breaking foodcritic #931

sbates opened this issue Dec 2, 2013 · 4 comments

Comments

@sbates
Copy link
Contributor

sbates commented Dec 2, 2013

Berks vendor causes a json file to be created from the metadata.rb and the metadata file is removed. When foodcritic is run locally against the vendored install, it breaks on FC045. For now we've added an ignore to the foodcritic rake task. I asked Ivey about this and he asked me to make an issue so it could be discussed.
@reset
Copy link
Contributor

reset commented Dec 2, 2013

@sbates this was an intentional change. Vendoring now compiles the raw metadata into the outputted artifact. With this in mind, Foodcritic shouldn't be run against the produced artifact and instead should be run on the source cookbook prior to vendoring.

@reset
Copy link
Contributor

reset commented Dec 2, 2013

You can see the pretty long chain of events here: #923 :)

@sethvargo
Copy link
Contributor

@sbates you can tell FC to ignore the vendor directory too 😄

@sbates
Copy link
Contributor Author

sbates commented Dec 3, 2013

Thanks guys. This was a combination of not understanding why vendoring and installing were different and their reasoning behind vendoring. I think we got it all sorted out.

openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-common that referenced this issue Sep 29, 2014
@iartarisi
add a Rakefile to structure test runs
80cd4b6 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: I3951f7bf3b474f1b7aab46c16d91a9b431a787bf
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-object-storage that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
6950ed5 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: I7fee4e90c2f50e3c8467a0af93118c696400eafb
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-image that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
d39c346 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: Iee61f2aecb237102b9caef6e298b0df85c24370b
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-ops-database that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
55f09a7 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: Ia822611f48f27b1027f508004150f83b0a2762f7
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-identity that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
3162168 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: I6e007888e1b37a54628ab5c09e62f636a0b622ed
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-database that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
42d99ea 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: I3acc8abe5209237a17d66bd3376102c9710f6127
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-orchestration that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
1687a25 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: Ia4d52047f1f20b4a62fd1c3726389f3ad562a968
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-ops-messaging that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
fa0ac9d 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: Ie245028db93d6d49eb224747f2c0697c9b6bdcf5
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-telemetry that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
c1f7d4e 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: If76f6fca62c7cff719e9a631c968a252cf30f10a
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-dashboard that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
e5c9b4b 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: I4d77e65dac01c138a82f1b11fefb8cc33cd04194
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-block-storage that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
17eff95 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: If366dff9394f416b0704bea89ae50c1c472606bf
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-network that referenced this issue Oct 7, 2014
@iartarisi
add a Rakefile to structure test runs
71ddd10 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: Iccc37e0fd46323f1f19bee32bda0a7a3ee8c3974
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-integration-test that referenced this issue Nov 17, 2014
add a Rakefile to structure test runs
996176b 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: Id085444027efd90049508abe6a309fed7dfffee8
blueprint: rakefile
openstack-gerrit pushed a commit to openstack-archive/cookbook-openstack-compute that referenced this issue Jan 19, 2015
@chenzhiwei
add a Rakefile to structure test runs
160dbd9 
Having a Rakefile will allow us to change the actual test commands on
our side rather than relying on changes to the openstack-infra
repository. This should make it a lot faster to change things, but also
easier to test since the jenkins jobs are actually run in this
repository, not the openstack-infra one.

This commit defines the jobs we previously had defined in Jenkins and
uses 'high-level' naming consistently (i.e. lint, style vs. foodcritic,
rubocop).

There is also a :clean task to help with deleting the files generated by
the other jobs.

Also changed foodcritic to run on the source cookbook rather than the
one installed by berks, see
e.g. berkshelf/berkshelf#931 (comment)

Change-Id: Ib3b22f4bd93cb277be9e8bea13a90210e0e755e1
blueprint: rakefile
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reset @sethvargo @sbates