Do not delete the vendor directory #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reset can you take a look at this when you have a minute please? |
| FileUtils.cp(source_file, "#{destination}/#{relative_path}") | ||
| else | ||
| raise RuntimeError, | ||
| "Unknown file type: `#{File.ftype(source_file)}' at `#{source_file}'!" |
There was a problem hiding this comment.
We should probably say what we were doing when we encountered the bad file, "Syncing X to X failed:"
|
@sethvargo looks good just rebase and reformat to match the Berkshelf coding style |
sethvargo
force-pushed
the
sethvargo/file_syncer
branch
from
a3279d3
to
99c83eb
Compare
|
@reset rebased and updated that error message. Are there any other style things you see that I need to cleanup? |
reset
added a commit
that referenced
this pull request
Oct 27, 2014
Do not delete the vendor directory
|
@sethvargo looks good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a file syncer to avoid deleting the vendor directory (previous behavior). This also updates and fixes the failing tests
/cc @reset @mikelococo