Do not leak tempdirs #1334
Merged
Do not leak tempdirs #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be nice and clean up after yo'self
|
@reset this involved switch to the block form of Dir.mktmpdir, which cleans up after itself. As a result, the diff is pretty annoying to read, but you can read it more easily if you turn off whitespace diffing with the w=1 URL trick. |
|
@sethvargo looks good to me 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be nice and clean up after yo'self!
Fixes #1333, although I can't speak for Ridley. I didn't have time to go digging there.
/cc @stevendanna