Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to generate metadata.json only in the vendored cookbook #1768

Merged
merged 1 commit into from Apr 30, 2018

Conversation

lamont-granquist
Copy link
Contributor

I thought the path argument to the compile_metadata() method was useless when I ported the method over from ridley, but it turns out it uses that here in order to construct the metadata only in the destination vendored directory, so I started to create litter in the root of the cookbook. There were no tests, so no indication that broke. There is now a test that will fail properly.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@lamont-granquist
Copy link
Contributor Author

closes #1767

@tas50
Copy link
Contributor

tas50 commented Apr 30, 2018

:shipit:

@lamont-granquist lamont-granquist merged commit 2cc4889 into master Apr 30, 2018
@lamont-granquist lamont-granquist deleted the lcg/vendor-metadata.json-handling branch April 30, 2018 21:57
@lock
Copy link

lock bot commented Jun 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants