Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI fix: remove '::' from module statements #1769

Merged
merged 1 commit into from May 1, 2018
Merged

CI fix: remove '::' from module statements #1769

merged 1 commit into from May 1, 2018

Conversation

lamont-granquist
Copy link
Contributor

@lamont-granquist lamont-granquist commented Apr 30, 2018 •
edited

Seeing piles of this only on sles-11 and el-6:

An error occurred while loading ./spec/unit/berkshelf/berksfile_spec.rb.
Failure/Error: module Berkshelf::RSpec

NameError:
  uninitialized constant Berkshelf
# ./spec/support/chef_server.rb:4:in `<top (required)>'
# ./spec/spec_helper.rb:12:in `require'
# ./spec/spec_helper.rb:12:in `block in <top (required)>'
# ./spec/spec_helper.rb:12:in `each'
# ./spec/spec_helper.rb:12:in `<top (required)>'
# ./spec/unit/berkshelf/berksfile_spec.rb:1:in `require'
# ./spec/unit/berkshelf/berksfile_spec.rb:1:in `<top (required)>'

An error occurred while loading ./spec/unit/berkshelf/berkshelf/api_client/connection_spec.rb.
Failure/Error: module Berkshelf::RSpec

NameError:
  uninitialized constant Berkshelf
# ./spec/support/chef_server.rb:4:in `<top (required)>'
# ./spec/spec_helper.rb:12:in `require'
# ./spec/spec_helper.rb:12:in `block in <top (required)>'
# ./spec/spec_helper.rb:12:in `each'
# ./spec/spec_helper.rb:12:in `<top (required)>'
# ./spec/unit/berkshelf/berkshelf/api_client/connection_spec.rb:1:in `require'
# ./spec/unit/berkshelf/berkshelf/api_client/connection_spec.rb:1:in `<top (required)>'

An error occurred while loading ./spec/unit/berkshelf/berkshelf/api_client/remote_cookbook_spec.rb.
Failure/Error: module Berkshelf::RSpec

@lamont-granquist
remove '::' from module statements
4f84ba6 
These can fail with "uninitialized constant Berkshelf" if the
`module Berkshelf` hasn't already been declared, which under some
kind of extremely strange conditions is failing on sles-11 and
el-6 in our CI system.

There is probably some fascinating reason why this is failing on
only those two distros, and I am hoping I don't have to actually
learn why.

If you'd like a plausible story, something about LC_COLLATE env
vars being different and leading to different file globbing
behavior would be my guess.

Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
@lamont-granquist lamont-granquist merged commit dbac3b2 into master May 1, 2018
@lamont-granquist lamont-granquist deleted the lcg/fix-crazy-ci-error branch May 1, 2018 01:17
@lock
Copy link

lock bot commented Jun 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tas50 tas50 tas50 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lamont-granquist @tas50