Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Strings to access options in try_download. Fixes #1764. #1782

Merged
merged 1 commit into from Aug 6, 2018

Conversation

xeron
Copy link
Contributor

@xeron xeron commented Jun 13, 2018

Fixes downloading from GHE endpoints (#1764).

options used to be some VariaModel::Attributes class which probably accepted both String and Symbol keys but since 7.0.0 it's just a Hash.

@xeron
Copy link
Contributor Author

xeron commented Jun 25, 2018

Anyone?

@lamont-granquist lamont-granquist merged commit 29864cc into berkshelf:master Aug 6, 2018
@xeron xeron deleted the fix-github-enterprise branch August 6, 2018 21:37
@lock
Copy link

lock bot commented Oct 5, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants