Specifying -c or --config during berks upload does nothing...

[sethvargo]

The only way to upload a cookbook to Chef Server is to continuously overwrite the ~/.berkshelf/config.json file. This is not very feasible when working with multiple Chef Server installations.

It always reads the ~/.berkshelf/config.json, regardless of the flag being specified.

[sethvargo]

Also see #202

[reset]

Hey Seth,

You should be able to specify the -c flag pointing to a different Berks config. Is that not working?

Jamie Winsor
@resetexistence

On Nov 10, 2012, at 9:51 PM, Seth Vargo notifications@github.com wrote:

The only way to upload a cookbook to Chef Server is to continuously overwrite the ~/.berkshelf/config.json file. This is not very feasible when working with multiple Chef Server installations.

—
Reply to this email directly or view it on GitHub.

[sethvargo]

Hey Jamie,

It doesn't appear to be working. This PR removes the attr_writer and defines an actual method for setting the path. Example:

# lib/berkshelf/cli.rb
def initialize(*args)
  super(*args)

  puts "@options[:config] was #{@options[:config]}" # add
  if @options[:config]
    unless File.exist?(@options[:config])
      raise BerksConfigNotFound, "You specified a path to a configuration file that did not exist: '#{@options[:config]}'"
    end
    puts "Setting Berkshelf::Config.path = #{@options[:config]}" # add
    Berkshelf::Config.path = @options[:config]
    puts "Berkshelf::Config.path is now #{@options[:config]}" # add
  end

  Berkshelf.set_format @options[:format]
  @options = options.dup # unfreeze frozen options Hash from Thor
end

Running bundle exec berks upload -c ./config.json will print:

@options[:config] was ./config.json
Setting Berkshelf::Config.path = ./config.json
Berkshelf::Config.path is now /Users/svargo/.berkshelf/config.json

The argument is clearly passed, but the path= method was not working with attr_writer. Take a look at the PR and let me know what you think.

[reset]

@sethvargo good catch - the writer should definitely expand the path when assigning.

[sethvargo]

<3