If there is a locked_version, check the CookbookStore directly #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivey @reset @andrewGarson 👀 please |
| Constraints are = 2.0.0 | ||
| Possible values are ["berkshelf", []] | ||
| Could not find an acceptable value for berkshelf | ||
| Cannot backtrack any further |
There was a problem hiding this comment.
This change is unrelated, but the tests were failing. I made the test more generic.
|
Looks good to me. Currently locked out of my laptop (which will explain any rage subtext to my tweets/emails ... Grar) so I can't test but I think this is a good change. |
This causes a dramatic speed improvement for already-downloaded dependencies and ensure the proper cookbook version is actually used.
|
@sethvargo is this just the optimization found in #829 but for the master branch? |
|
@reset no. Using #satisfy is significantly (like seconds) slower when finding a cookbook and is O(n^2) proportional to the size of your Berkshelf. The #cookbook method is an O(1) operation because it just looks for a folder. |
|
@sethvargo ok so we still need to pull in #829 then? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a dramatic speed improvement for already-downloaded dependencies and ensure the proper cookbook version is actually used.