This repository has been archived by the owner on Mar 21, 2018. It is now read-only.
Add buff-ignore; correctly apply chefignore #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # @return [Boolean] | ||
| # true if it should be ignored, false otherwise | ||
| def ignored?(file) | ||
| !!chefignore && chefignore.send(:ignored?, file) |
There was a problem hiding this comment.
why is this a private function on the Chefignore?
There was a problem hiding this comment.
It can be made public, but the ignore file should really only respond to #apply, given an array argument. I can make the method public if that makes more sense though.
There was a problem hiding this comment.
I think it makes sense to make the Chefignore class a bit more flexible
|
@sethvargo the build is still failing on this branch |
|
@reset right, we talked about it in code review. I don't have a sustainable way to test this and needed some pointers. The order for SHAs is not guaranteed |
|
@reset I had to call |
reset
added a commit
that referenced
this pull request
Jul 18, 2013
Add buff-ignore; correctly apply chefignore
bflad
added a commit
to sous-chefs/docker
that referenced
this pull request
Oct 5, 2013
bflad
added a commit
to bflad/chef-cacti
that referenced
this pull request
Oct 5, 2013
bflad
added a commit
to sous-chefs/confluence
that referenced
this pull request
Oct 5, 2013
bflad
added a commit
to bflad/chef-jira
that referenced
this pull request
Oct 5, 2013
bflad
added a commit
to bflad/chef-mysql_connector
that referenced
this pull request
Oct 5, 2013
bflad
added a commit
to bflad/chef-oculus
that referenced
this pull request
Oct 5, 2013
bflad
added a commit
to bflad/chef-scipy
that referenced
this pull request
Oct 5, 2013
bflad
added a commit
to bflad/chef-skyline
that referenced
this pull request
Oct 5, 2013
bflad
added a commit
to bflad/chef-stash
that referenced
this pull request
Oct 5, 2013
jasmeralia
pushed a commit
to jasmeralia/chef-cacti
that referenced
this pull request
Dec 29, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reset 👀