Skip to content
This repository has been archived by the owner on Dec 26, 2017. It is now read-only.

Ignore plugin when no Berksfile found #6

Closed
zimbatm opened this issue Mar 22, 2013 · 6 comments
Closed

Ignore plugin when no Berksfile found #6

zimbatm opened this issue Mar 22, 2013 · 6 comments
Labels
Milestone

Comments

@zimbatm
Copy link

zimbatm commented Mar 22, 2013

Right now vagrant will stop the provisioning if the Berksfile is not found. This should be changed to a warning.

[default] Matching MAC address for NAT networking...
[default] Setting the name of the VM...
[default] Clearing any previously set forwarded ports...
Berkshelf::BerksfileNotFound: No Berksfile or Berksfile.lock found at: /path/to/my/project/Berksfile

This breaks vagrant on my other projects where I don't use berkshelf.

@mlafeldt
Copy link

That's indeed an annoying bug.

Workaround for now: touch Berksfile

@zimbatm
Copy link
Author

zimbatm commented Mar 22, 2013

True. I had a quick look in the code but things seems quite linked together.

Maybe it would be reasonable to not auto-include the provisioner and ask people to change their Vagrantfile to add the provisioner themselves. This would make things much more explicit and it would still be possible to hard-fail in case the Berkshelf file would be missing in that case.

Vagrant::Config.run do |config|
  config.vm.box = "precise64"
  config.vm.provision :berkshelf # we could even pass the path to the Berksfile here
  config.vm.provision :chef_solo do |chef|
    #...
  end
end

Would that make sense ?

@reset
Copy link
Contributor

reset commented Mar 22, 2013

@zimbatm we're aware of this issue and it is one of the first items to address

@mlafeldt
Copy link

@reset @mitchellh I'm also curious how to update Vagrant plugins? Run vagrant plugin install again?

@mitchellh
Copy link

Yeah.

I'll add an "update" command in the future but "install" will always get the latest and overwrite existing.

Sent from my iPhone

On Mar 24, 2013, at 2:35 AM, Mathias Lafeldt notifications@github.com wrote:

@reset @mitchellh I'm also curious how to update Vagrant plugins? Run vagrant plugin install again?


Reply to this email directly or view it on GitHub.

@reset
Copy link
Contributor

reset commented Apr 11, 2013

#16 adds the 'berkshelf.enabled' configuration which is disabled by default

@reset reset closed this as completed Apr 11, 2013
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants