Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow validateSession to return a promise #33

Closed
darkrift opened this issue Jun 22, 2018 · 1 comment · Fixed by #36
Closed

Allow validateSession to return a promise #33

darkrift opened this issue Jun 22, 2018 · 1 comment · Fixed by #36

Comments

@darkrift
Copy link
Contributor

Locally validating the token is only the first step but the real deal is to know if the server still have that session token active/alive (maybe the server restarted, the session has been killed by some other admin users, etc) so a server call will most likely always be required to determine if the client token is still valid.

Currently the validateSession option must be a pure function that requires an immediate returned value but allowing the returned value to be a promise would allow server validation and fix the described problem.

@austencm
Copy link

austencm commented Jul 4, 2018

Agreed. This seems crucial for validateSession to be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants