Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The app doesn't run with stable v1.12.13+hotfix.5 #2

Closed
humazed opened this issue Dec 27, 2019 · 9 comments
Closed

The app doesn't run with stable v1.12.13+hotfix.5 #2

humazed opened this issue Dec 27, 2019 · 9 comments

Comments

@humazed
Copy link

humazed commented Dec 27, 2019

Running with flutter v1.12.13+hotfix.5 the app just crashes with no error message.
I see you included a web folder which means it's built with the beta version at least.
which version of flutter should I use to run the app?

@Shubxam
Copy link

Shubxam commented Dec 27, 2019

I can confirm this behavior.

@bernaferrari
Copy link
Owner

bernaferrari commented Dec 27, 2019

Uhhhh ohh. I'm testing in dev (1.13.5 framework revision 41a911099b) in macOS. Could you try in dev branch and tell me what happens?

I tried it here on the web and worked fine.

ChangeDetection

@jshvarts
Copy link

Possibly related: Running gradlew build in android getting build failure.

lib/example/mdc/showcase.dart:173:27: Error: No named parameter with the name 'clipBehavior'.
                          clipBehavior: Clip.antiAlias,
                          ^^^^^^^^^^^^
../../development/flutter/packages/flutter/lib/src/widgets/container.dart:302:3: Context: Found this candidate, but the arguments don't match.
  Container({
  ^^^^^^^^^
Target kernel_snapshot failed: Exception: Errors during snapshot creation: null
build failed.

> Task :app:compileFlutterBuildDebug FAILED

FAILURE: Build failed with an exception.

@bernaferrari
Copy link
Owner

Thanks! @jshvarts

I know what went wrong. ClipBehavior on Container was commited 24 days ago and is available since 1.13.0, but not on stable. I have just replaced it with something else. Could you all try again?!

flutter/flutter@f68cdac#diff-26623f46f87b8f10fdcf148c2e53469a

@jshvarts
Copy link

jshvarts commented Dec 27, 2019

Builds and runs fine in AS now!

gradlew build now gives me a test failure but at least I can build it in AS.

> Task :path_provider:testDebugUnitTest FAILED
io.flutter.plugins.pathprovider.StorageDirectoryMapperTest > testAndroidType_valid FAILED
    java.lang.IllegalArgumentException at StorageDirectoryMapperTest.java:28
3 tests completed, 1 failed
FAILURE: Build failed with an exception.

@bernaferrari
Copy link
Owner

.___. I'll give a look into this (plus, the signing issues with gradle). Thanks!

@bernaferrari
Copy link
Owner

Issues with Gradle solved. After initial flutter pub get it should work without errors in Android and iOS (after pod install).

@jshvarts
Copy link

hmmm...still see the same test failure

@bernaferrari
Copy link
Owner

I'm not sure where that is coming from. Couldn't find anything. But as long as you can run it, it should be fine. Feel free to tell if anything weird ever happens again. I'm also setting up GitHub Actions with the stable release of Flutter, so this issue never happens with you or anyone else ever again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants