System checks of INSTALLED_APPS #545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd settings.TENANT_APPS, it doesn't make sense to compare with app_configs. We had to change this to be able to use Sentry. Sentry's Django AppConfig's name is "raven.contrib.django", but in INSTALLED_APPS you write "raven.contrib.django.raven_compat".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #443
The system check
best_practicegets a list of INSTALLED_APPS from theapp_configsparameter but then it compares it withsettings.SHARED_APPSandsettings.TENANT_APPS. I changed it so that it also usessettings.INSTALLED_APPSinstead of using theapp_configsparameter.We had to change this to be able to use Sentry. Sentry's Django AppConfig's name is "raven.contrib.django", but in INSTALLED_APPS (according to the docs) you write "raven.contrib.django.raven_compat".
There's probably a problem in the way the Raven app is configured, since its
AppConfig.nameshould be the full Python path to the app. But I also think that this fix indjango-tenant-schemasis in order.What do you think?