Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement #118: Adding riverside location and achievement #418

Closed

Conversation

Immutablevoid
Copy link
Contributor

After manual testing and running mvn test, changes seems to work successfully.

  • Added location riverside
  • Added functions for riverside location to only appear left and right of river/bridge location
  • Added achievement for visiting 10 different riverside (Not sure how rewarding this achievement is, since riversides spawn along the river)
  • Edited AchievementsJsonFileTest.java to include rule for new riverside achievement. (Unsure what the rule functionality does, even after looking through it)

@bernardosulzbach
Copy link
Owner

Of very high quality and works well.

Thank you.

When I added the achievements I ended up creating several unimaginative ones to be able to test the system. Maybe one day the game will have enough content to allow for a good number of meaningful, challenging achievements.

As a side note, I changed the commit message slightly. See this, for instance, which are some good guidelines. Mostly items 1 through 4.

@bernardosulzbach
Copy link
Owner

Closing manually, already rebased.

@Immutablevoid
Copy link
Contributor Author

Oh, Thank you very much. I really like this project and it's concept. I will probably do more contributions when I have free time.

Oh and Thanks for the article ill go through it.

@Immutablevoid Immutablevoid deleted the issue118 branch October 30, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants