Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All of our code should be in our namespace #32

Open
bernardosulzbach opened this issue May 28, 2020 · 1 comment
Open

All of our code should be in our namespace #32

bernardosulzbach opened this issue May 28, 2020 · 1 comment
Assignees
@bernardosulzbach
Labels
analysis An idea still being considered error A possible cause of a fault

Comments

@bernardosulzbach
Copy link
Owner

I just noticed that ArgumentParser is not in our namespace.
@bernardosulzbach bernardosulzbach added analysis An idea still being considered error A possible cause of a fault labels May 28, 2020
@bernardosulzbach bernardosulzbach self-assigned this May 28, 2020
@bernardosulzbach
Copy link
Owner Author

An easy way to test if this seems to be the case for all headers is to compare the output of the following commands.

la src | grep -i hpp | wc -l
git grep "namespace WayoutPlayer {" | grep -i hpp | wc -l

It can be compared automatically by calling this:

diff <(la src | grep -i hpp | wc -l) <(git grep "namespace WayoutPlayer {" | grep -i hpp | wc -l)

bernardosulzbach added a commit that referenced this issue May 28, 2020
@bernardosulzbach
Ensures all declarations are in our namespace
4c12528 
Closes #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bernardosulzbach bernardosulzbach

Labels
analysis An idea still being considered error A possible cause of a fault
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bernardosulzbach