improve(slide): do not use translation easing while dragging

berndartmueller · Aug 28, 2020 · 3470358 · 3470358
1 parent dbeb942
commit 3470358
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 7 deletions.
diff --git a/src/slide.ts b/src/slide.ts
@@ -76,13 +76,14 @@ export class Slide {
   /**
    * Start transition.
    *
-   * @param value
-   * @param done
+   * @param value Position to translate to.
+   * @param easing Enable or disable transition easing.
+   * @param done Callback function after transition has ended.
    */
-  translate(value: number, done = noop) {
-    this.transitionEndCallback = done;
+  translate(value: number, { easing, done }: { easing?: boolean; done?: identity } = {}) {
+    this.transitionEndCallback = done || noop;
 
-    this.ref.style.transition = `transform ${this.settings.speed}ms ${this.settings.easing}`;
+    this.ref.style.transition = `transform ${this.settings.speed}ms ${easing ? this.settings.easing : 'ease'}`;
     this.ref.style.transform = `translate3d(calc(${this.position}% + ${Math.round(value)}px), 0, 0)`;
   }
 

diff --git a/src/virchual.ts b/src/virchual.ts
@@ -164,8 +164,11 @@ export class Virchual {
   private goTo(control: 'prev' | 'next') {
     const slide = this.slides[this.currentIndex];
 
-    slide.translate(-100, () => {
-      this.isBusy = false;
+    slide.translate(-100, {
+      easing: true,
+      done: () => {
+        this.isBusy = false;
+      },
     });
 
     const sign: Sign = control === 'prev' ? -1 : +1;