Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add batchtools mode to parallelLibrary() #70

Merged
merged 5 commits into from
Jan 2, 2020

Conversation

dagola
Copy link

@dagola dagola commented Jul 12, 2019

Allow to add packages to a batchtools library.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 81.148% when pulling 5eb52c7 on dagola:dagola-feature_batchtools into f69e6a2 on berndbischl:master.

@pat-s
Copy link
Member

pat-s commented Dec 20, 2019

@dagola Thanks for contributing and sorry for the late reply. I assume you tested this locally?

There is currently not test for parallelLibrary() yet.
If you add an entry to NEWS we can merge this.

Also, feel free to add yourself as a contributor :)

@codecov-io
Copy link

codecov-io commented Dec 29, 2019

Codecov Report

Merging #70 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   80.68%   80.91%   +0.22%     
==========================================
  Files          20       20              
  Lines         585      592       +7     
==========================================
+ Hits          472      479       +7     
  Misses        113      113
Impacted Files Coverage Δ
R/parallelLibrary.R 89.58% <100%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20b8e99...880c93f. Read the comment docs.

@dagola
Copy link
Author

dagola commented Dec 29, 2019

@pat-s Yes, I tested it locally. Basically, it's just a modified copy of the BatchJobs part.

@pat-s pat-s merged commit e40a10e into mlr-org:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants