enable gosec linter again

Signed-off-by: Bernd Verst <4535280+berndverst@users.noreply.github.com>

.golangci.yml

@@ -260,7 +260,6 @@ linters:
     - godot
     - cyclop
     - varnamelen
-    - gosec
     - errorlint
     - forcetypeassert
     - ifshort

internal/eventbus/event_bus_test.go

@@ -16,6 +16,7 @@ The MIT License (MIT)
 Copyright (c) 2014 Alex Saskevich
 */
 
+//nolint:errcheck
 package eventbus
 
 import (

secretstores/azure/keyvault/keyvault.go

@@ -186,8 +186,7 @@ func (k *keyvaultSecretStore) getVaultURI() string {
 
 func (k *keyvaultSecretStore) getMaxResultsFromMetadata(metadata map[string]string) (*int32, error) {
 	if s, ok := metadata["maxresults"]; ok && s != "" {
-		/* #nosec */
-		val, err := strconv.Atoi(s)
+		val, err := strconv.Atoi(s) //nolint:gosec
 		if err != nil {
 			return nil, err
 		}

state/mongodb/mongodb.go

@@ -66,7 +66,7 @@ const (
 	connectionURIFormatWithSrv = "mongodb+srv://%s/%s"
 
 	// mongodb+srv://<username>:<password>@<server>/<params>
-	connectionURIFormatWithSrvAndCredentials = "mongodb+srv://%s:%s@%s/%s%s"
+	connectionURIFormatWithSrvAndCredentials = "mongodb+srv://%s:%s@%s/%s%s" //nolint:gosec
 )
 
 // MongoDB is a state store implementation for MongoDB.

state/mysql/mysql.go

@@ -245,6 +245,11 @@ func (m *MySQL) ensureStateTable(stateTableName string) error {
 		// never need to pass it in.
 		// eTag is a UUID stored as a 36 characters string. It needs to be passed
 		// in on inserts and updates and is used for Optimistic Concurrency
+
+		// adding a basic precaution to ensure our SQL query is not hijacked
+		stateTableName = strings.Split(strings.Split(stateTableName, ";")[0], " ")[0]
+
+		//nolint:gosec
 		createTable := fmt.Sprintf(`CREATE TABLE %s (
 			id VARCHAR(255) NOT NULL PRIMARY KEY,
 			value JSON NOT NULL,

tests/conformance/state/state.go

@@ -425,7 +425,8 @@ func ConformanceTests(t *testing.T, props map[string]string, statestore state.St
 				}
 			}
 
-			transactionStore := statestore.(state.TransactionalStore)
+			transactionStore, ok := statestore.(state.TransactionalStore)
+			assert.True(t, ok)
 			sort.Ints(transactionGroups)
 			for _, transactionGroup := range transactionGroups {
 				t.Logf("Testing transaction #%d", transactionGroup)
@@ -547,7 +548,8 @@ func ConformanceTests(t *testing.T, props map[string]string, statestore state.St
 			}
 
 			// Act
-			transactionStore := statestore.(state.TransactionalStore)
+			transactionStore, ok := statestore.(state.TransactionalStore)
+			assert.True(t, ok)
 			err = transactionStore.Multi(&state.TransactionalStateRequest{
 				Operations: operations,
 				Metadata:   partitionMetadata,