New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gradient stroke #5

Closed
wants to merge 1 commit into
base: gh-pages
from

Conversation

Projects
None yet
2 participants
@samccone

samccone commented Aug 11, 2012

so, you had a gradient stroke here, it made the stroke look really bad against a dark BG and .. well basically it was unneeded

@ghost ghost assigned bernii Aug 15, 2012

@bernii

This comment has been minimized.

Show comment
Hide comment
@bernii

bernii Aug 15, 2012

Owner

I think that gradient trick is still needed here, you can use it to add a nice looking inner shadow to the Donut.
You are right that it might now always work on dark backgrounds. That's why I've added shadowColor option to Donut in new version where you can define it.

Owner

bernii commented Aug 15, 2012

I think that gradient trick is still needed here, you can use it to add a nice looking inner shadow to the Donut.
You are right that it might now always work on dark backgrounds. That's why I've added shadowColor option to Donut in new version where you can define it.

@samccone

This comment has been minimized.

Show comment
Hide comment
@samccone

samccone Aug 15, 2012

right you can* use it, why not just allow the user to pass a gradient if they want to.. like this code allows for

samccone commented Aug 15, 2012

right you can* use it, why not just allow the user to pass a gradient if they want to.. like this code allows for

@bernii

This comment has been minimized.

Show comment
Hide comment
@bernii

bernii Aug 15, 2012

Owner

Got your point. Added option called generateGradient that is turned off by default (so you can use any fill you like) but can be use to automatically generate shadow gradient.

Owner

bernii commented Aug 15, 2012

Got your point. Added option called generateGradient that is turned off by default (so you can use any fill you like) but can be use to automatically generate shadow gradient.

@bernii bernii closed this Aug 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment