Feat/allow other usernames with root access #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user from playbooks
…/manifest/utils.go
cloudziu
suggested changes
Apr 11, 2024
cloudziu
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1297
This PR allows other usernames with root access in the static nodes.
claudie-operatorchecks if a user with the provided username can SSH into the node and whether the user is part of thesudogroup. Because if the user isn't in thesudogroup Claudie assumes the user doesn't have required root privileges.If the provided username can't be used for SSH or the user with this username isn't in the
sudogroup,claudie-operatordoesn't start the workflow. Users can see the errors regarding this failure in the logs of theclaudie-operatorpod only.Any comments and suggestions are most welcome.