-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/multiple providers #1348
Fix/multiple providers #1348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT 👍
Just one more question. Why do we use region in the provider.alias
for most of the cloud providers and some (Hetzner) we don't?
This is the case for the hetzner as the networking stuff doesn't have to be region specific. Moreover, hetzner doesn't allow to create the same ssh keys (they check based on the key fingerprint) so it is not possible to have more than one hetzner provider in the same cluster (unless two completely different hetzner accounts will be used in which case it will work) |
And why isn't it possible to omit EDIT: If I am not mistaken the |
For some providers you need the region (for example for aws and gcp, oci...,
You could have different nodepools from the same provider but in different regions. |
Okay, got it. Thanks. |
# Conflicts: # manifests/claudie/kustomization.yaml # manifests/testing-framework/kustomization.yaml
Closes #1296
Closes #1312
This PR also introduces a limit on names for:
clusters: 28 chars.
nodepools: 14 chars.
Note: Mostly the changes are in the terraform files where everything has a "provider.specName" suffix so that no collisions will be generated when using more than one of the same provider