Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update backup method #1375

Merged
merged 8 commits into from
May 9, 2024
Merged

update backup method #1375

merged 8 commits into from
May 9, 2024

Conversation

Despire
Copy link
Contributor

@Despire Despire commented May 7, 2024

Closes #1349

@Despire Despire added the refresh-docs Trigger automatic update of the latest docs version. /refresh-docs comment is also a trigger. label May 7, 2024
@Despire Despire requested a review from bernardhalas May 7, 2024 10:30
@Despire Despire requested a review from JKBGIT1 May 7, 2024 13:28
JKBGIT1
JKBGIT1 reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@JKBGIT1 JKBGIT1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the backup of Claudie's secrets (kubeconfig, metadata) in a manual approach?
Should we provide a guide or mention that these data won't be backed? Do they "re-create" after the user applies new changes through IM?

docs/creating-claudie-backup/creating-claudie-backup.md Outdated Show resolved Hide resolved
@Despire
Copy link
Contributor Author

Despire commented May 7, 2024

Do they "re-create" after the user applies new changes through IM?

Yes. On new changes the worfklow will run which will also recreate all of the secrets

@Despire
Copy link
Contributor Author

Despire commented May 7, 2024

Should we provide a guide or mention that these data won't be backed?

I think so.

@Despire Despire requested a review from JKBGIT1 May 7, 2024 14:37
JKBGIT1
JKBGIT1 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@JKBGIT1 JKBGIT1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Despire and others added 2 commits May 8, 2024 16:18
@Despire @bernardhalas
Update docs/creating-claudie-backup/creating-claudie-backup.md
c500cdd 
Co-authored-by: Bernard Halas <bernard.halas@berops.com>
@bernardhalas
Chore: Re-order the backup methods (#1376)
958e117 
Velero is the primary way, therefore it should be mentioned first.
bernardhalas
bernardhalas approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@bernardhalas bernardhalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Despire Despire added this pull request to the merge queue May 9, 2024
Merged via the queue into master with commit 158ff81 May 9, 2024
5 of 6 checks passed
@Despire Despire deleted the chore/update branch May 9, 2024 07:15
@Despire
Copy link
Contributor Author

Despire commented May 9, 2024

/refresh-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bernardhalas bernardhalas bernardhalas approved these changes

@JKBGIT1 JKBGIT1 JKBGIT1 approved these changes

Assignees
No one assigned
Labels
refresh-docs Trigger automatic update of the latest docs version. /refresh-docs comment is also a trigger.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Ensure Backup-Restore Procedure Works on Minikube and Kind
3 participants
@Despire @bernardhalas @JKBGIT1