-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: sanitise log/console secrets #535
bugfix: sanitise log/console secrets #535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf.
In the description for #529 I mention that there is a possibility that other credentials are in logs, more concretely in command
package (i.e. when retrying kubectl command with kubeconfig inside). Could you have a look and resolved it as well?
🚀
as suggested, I tried fixing it at the source - the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job :)
I like the implementation, from a functional point of view, although, I left a comment, which we can discuss if needed.
* use ansibler image from master for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks for the reviews @MiroslavRepka 🚀 |
fixes #529
list of issues fixed by this PR:
kubectl
) logging that containskubeconfig
files with certificates