Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/node labels #543

Merged
merged 7 commits into from
Feb 1, 2023
Merged

Feat/node labels #543

merged 7 commits into from
Feb 1, 2023

Conversation

MiroslavRepka
Copy link
Contributor

This PR adds default node labels as discussed. All labels are added via kubeone so the changes in our code are minimal.

All nodes will have labels

claudie.io/worker-node: # true or false
claudie.io/provider: # cloud provider name [hetzner, gcp, oci, ...]
claudie.io/provider-instance: # cloud provider instance [hetzner-1, gcp-1, gcp-2, ...]
claudie.io/nodepool: # nodepool name

topology.kubernetes.io/region: # region name
topology.kubernetes.io/zone: # zone name

The storage classes in longhorn are now configured based on cloud provider instance, instead of cloud provider as described in #472.
The topology labels also improve Longhorn scheduling as described in #425.

@MiroslavRepka MiroslavRepka added the enhancement New feature or request label Jan 27, 2023
@MiroslavRepka MiroslavRepka self-assigned this Jan 27, 2023
Copy link
Contributor

@Despire Despire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues, LGTM.

@MiroslavRepka MiroslavRepka merged commit c3556a2 into master Feb 1, 2023
@MiroslavRepka MiroslavRepka deleted the feat/node-labels branch February 1, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants