Feat/cluster processing #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM, great job @Despire! I left some comments, just minor changes if anything.
MiroslavRepka
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #477
This PR implements a per-cluster processing of the config. Since while building the cluster we also need the loadbalancers at some points I didn't seperate the workflow for Lbs from the kubernetes clusters.
The idea is that everything a cluster needs during a workflow execution is stored in the BuildContext. After a successfull workflow the changes made within that context are then propagated back
To be able to process the cluster individually I had to create another "view" that would just aggregate the data per cluster thus the ClusterView struct
Any changes made are than propagated back to the config and saved to the DB