Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cluster Autoscaler integration #644

Merged
merged 158 commits into from
Apr 5, 2023
Merged

Cluster Autoscaler integration #644

merged 158 commits into from
Apr 5, 2023

Conversation

MiroslavRepka
Copy link
Contributor

This PR integrates Cluster Autoscaler into the Claudie, by implementing autoscaler-adapter, which is just an implementation of external gRPC provider.

Things that are implemented:

  • Autoscaler adapter
  • Autoscaler deployment procedure
  • Autoscaler testing in CI
  • Docs updation

Things which need to be done:

  • Add configuration option for CA?
  • Add kubernetes.io/arch label implementation
  • Dynamically change Autoscaler versions based on cluster version
  • possibly other features (expanders, etc.)

The diff might seem large, however, a lot of files were changed only due to renaming Berops to berops. Please, review carefully.

@MiroslavRepka
Add parsing of the input manifest
8cd766e
@MiroslavRepka
Rename Berops tp berops
eb4597d
@MiroslavRepka
Small changes
80ecb2e
@MiroslavRepka
Improve logs
6247a18
@MiroslavRepka
Merge branch 'master' into feat/grpc-external-autoscaler-provider
fda741d
@MiroslavRepka
Merge conflicts
b7d9b06
@MiroslavRepka
Add node manager and new cache
f823d2f
@MiroslavRepka
Cache only autoscaler nodepools
9f3dac0
@MiroslavRepka
Rename proto makerule
a0abbc4
@MiroslavRepka
Add kubectl patch
7851aec
@MiroslavRepka
Add new RPC method
5b9ae17
@MiroslavRepka
Bugfixes
2d1925b
@MiroslavRepka
Implement patching of the ProviderID
fee1412
@MiroslavRepka
Rename a label
ad4963c
@MiroslavRepka
Merge branch 'master' into feat/grpc-external-autoscaler-provider
4075fcd
@MiroslavRepka
Update cache when installing dep
06090a5
@MiroslavRepka
Add LB to print
f6b7c59
@MiroslavRepka
Fix error message
63b7f2a
@MiroslavRepka
Refactor templates
5c367a5
@MiroslavRepka
Merge branch 'master' into feat/grpc-external-autoscaler-provider
9a80b88
@MiroslavRepka
Clean up
19fe5bd
@MiroslavRepka
Implement granular node deletion
fd6e83e
@MiroslavRepka
Fix removal of prefix
d7590bd
@MiroslavRepka
Replace assumption with node name
da9ff3b
@MiroslavRepka
Fix missing ClusterID
adff464
@MiroslavRepka
Integrate cluster autoscaler to claudie
514020c
@MiroslavRepka
Fix applying of CA
6367b47
@MiroslavRepka
Add missing args to request
7a78955
@MiroslavRepka
Add port to template data
b624611
@MiroslavRepka
Add Test for templates
7e7ccbe
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf approved these changes Mar 31, 2023
View reviewed changes
docs/claudie-workflow/claudie-workflow.md Outdated Show resolved Hide resolved
docs/claudie-workflow/claudie-workflow.md Outdated Show resolved Hide resolved
docs/autoscaling/autoscaling.md Outdated Show resolved Hide resolved
docs/autoscaling/autoscaling.md Outdated Show resolved Hide resolved
docs/autoscaling/autoscaling.md Outdated Show resolved Hide resolved
internal/kubectl/kubectl.go Outdated Show resolved Hide resolved
internal/manifest/validate_test.go Show resolved Hide resolved
proto/contextBox.proto Outdated Show resolved Hide resolved
proto/kuber.proto Outdated Show resolved Hide resolved
services/autoscaler-adapter/node_manager/node_manager.go Show resolved Hide resolved
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

I dig this 🚀
image

@MiroslavRepka MiroslavRepka added this pull request to the merge queue Apr 5, 2023
Merged via the queue into master with commit cfdf7d0 Apr 5, 2023
@MiroslavRepka MiroslavRepka deleted the feat/grpc-external-autoscaler-provider branch April 5, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKBGIT1 JKBGIT1 JKBGIT1 left review comments

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf approved these changes

@cloudziu cloudziu cloudziu approved these changes

@MarioUhrik MarioUhrik MarioUhrik approved these changes

@bernardhalas bernardhalas Awaiting requested review from bernardhalas

Assignees

@MiroslavRepka MiroslavRepka

Labels
feature New feature go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MiroslavRepka @bernardhalas @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf @cloudziu @JKBGIT1 @MarioUhrik